[Jool-list] Patch: RHEL/CentOS build fixes for Jool 3.4.2 (closes Issue #105)

[Terry Froy]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi folks,

We use Jool in production on our NAT64 gateways and find it more
'complete' than the NAT64 support in OpenBSD.

That said, I recently upgraded our Jool hosts to CentOS 7.2 to find that
the latest version of Jool (3.4.2 at time of writing) will not build
successfully on CentOS 7.2.

A quick check through the bug tracker found this:

https://github.com/NICMx/Jool/issues/105

Unfortunately, this was not the problem that I was seeing but after
reading issue #105 and the corresponding Stack Overflow question asked
by Alberto that was referenced in issue #105, the detail of the question
was sufficient to point me in the right direction to fix my particular
build issues - while working on my patch, it seemed reasonable to fix
the original issue #105 reported in the bug tracker even though it was
not affecting us directly but simply because it was The Right Thing To
Do(tm).

The attached patch applies cleanly to Jool 3.4.2, tries to supplement
the existing kernel version check logic and tries hard not to replace
any such logic except where necessary; my testing has been focused on
CentOS 7.0, 7.1 and 7.2 kernels to ensure that everything builds
correctly on those platforms with no errors or warnings but I have taken
special care to ensure that non-RHEL codepaths have *not* been modified
so any testing should be focused on non-RHEL platforms to ensure the
patch does not cause any regressions.

If the patch is not suitable for inclusion in Jool for whatever reason,
I believe that the code should still serve as a suitable answer to
Alberto's Stack Overflow question.

P.S. Happy New Year to all!

Regards,
Terry
- -- 
Terry Froy
Spilsby Internet Solutions
http://www.spilsby.net/

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEARECAAYFAlaGXUMACgkQpSya/lqjFqCtdgCfZPOwsBw1TXXzG5Mcky0ucudr
Eq4An2pJVB/qDcSDkCDwUPXjj0hozJuC
=D2y0
-----END PGP SIGNATURE-----

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20160101-jool-3.4.2-el7-build-fixes.patch
Type: text/x-patch
Size: 5095 bytes
Desc: not available
URL: <http://mail-lists.nic.mx/pipermail/jool-list/attachments/20160101/58f9c123/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20160101-jool-3.4.2-el7-build-fixes.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <http://mail-lists.nic.mx/pipermail/jool-list/attachments/20160101/58f9c123/attachment-0001.bin>